update pipelining tutorial #3182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3182
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit eca31e2 with merge base 7038ce7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
approved these changes
Dec 11, 2024
wconstab
reviewed
Dec 12, 2024
| x = x.to(device) | ||
| y = y.to(device) | ||
|
|
||
| def tokenwise_loss_fn(outputs, targets): | ||
| loss_fn = nn.CrossEntropyLoss() | ||
| outputs = outputs.view(-1, model_args.vocab_size) | ||
| targets = targets.view(-1) | ||
| outputs = outputs.reshape(-1, model_args.vocab_size) |
There was a problem hiding this comment.
Just curious, why this change?
There was a problem hiding this comment.
These changes weren't necessary but I do think they are clearer
wconstab
approved these changes
Dec 12, 2024
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tutorial to work with latest API changes